Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link test using old param name #311

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix link test using old param name #311

merged 1 commit into from
Feb 16, 2024

Conversation

mattjala
Copy link
Contributor

The test used the old parameter group_ids instead of the new grp_ids, causing the parameter to go unrecognized and the test to fail every time.

@mattjala mattjala added the ci/cd Issues related to the CI/CD setup and execution label Feb 15, 2024
@mattjala mattjala mentioned this pull request Feb 15, 2024
Merged
@jreadey jreadey self-assigned this Feb 16, 2024
jreadey
jreadey approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jreadey jreadey merged commit d0fe331 into HDFGroup:master Feb 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreadey jreadey jreadey approved these changes

Assignees

@jreadey jreadey

Labels
ci/cd Issues related to the CI/CD setup and execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjala @jreadey